Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: To many distracted messages came from monitor_sub_pools #587

Closed
qinxuye opened this issue Jul 10, 2023 · 3 comments · Fixed by #589
Closed

BUG: To many distracted messages came from monitor_sub_pools #587

qinxuye opened this issue Jul 10, 2023 · 3 comments · Fixed by #589
Labels
bug Something isn't working
Milestone

Comments

@qinxuye
Copy link
Contributor

qinxuye commented Jul 10, 2023

Describe the bug

A clear and concise description of what the bug is.

The message shown below may show too much times, it's quite distracted and may bury the real error.

2023-07-10 11:39:51,144 xoscar.backends.pool 2887043 ERROR    Monitor sub pool 127.0.0.1:37853 failed
Traceback (most recent call last):
  File "/usr/local/python3/lib/python3.11/site-packages/xoscar/backends/pool.py", line 1342, in monitor_sub_pools
    if not await self.is_sub_pool_alive(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/python3/lib/python3.11/site-packages/xoscar/backends/indigen/pool.py", line 310, in is_sub_pool_alive
    return await asyncio.to_thread(process.is_alive)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/python3/lib/python3.11/asyncio/threads.py", line 25, in to_thread
    return await loop.run_in_executor(None, func_call)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "uvloop/loop.pyx", line 2729, in uvloop.loop.Loop.run_in_executor
  File "/usr/local/python3/lib/python3.11/concurrent/futures/thread.py", line 167, in submit
    raise RuntimeError('cannot schedule new futures after shutdown')
RuntimeError: cannot schedule new futures after shutdown
2023-07-10 11:39:51,146 xoscar.backends.pool 2887043 ERROR    Monitor sub pool 127.0.0.1:41267 failed
Traceback (most recent call last):
  File "/usr/local/python3/lib/python3.11/site-packages/xoscar/backends/pool.py", line 1342, in monitor_sub_pools
    if not await self.is_sub_pool_alive(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/python3/lib/python3.11/site-packages/xoscar/backends/indigen/pool.py", line 310, in is_sub_pool_alive
    return await asyncio.to_thread(process.is_alive)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/python3/lib/python3.11/asyncio/threads.py", line 25, in to_thread
    return await loop.run_in_executor(None, func_call)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "uvloop/loop.pyx", line 2729, in uvloop.loop.Loop.run_in_executor
  File "/usr/local/python3/lib/python3.11/concurrent/futures/thread.py", line 167, in submit
    raise RuntimeError('cannot schedule new futures after shutdown')
RuntimeError: cannot schedule new futures after shutdown
@XprobeBot XprobeBot added the bug Something isn't working label Jul 10, 2023
@XprobeBot XprobeBot added this to the v0.4.1 milestone Jul 10, 2023
@qinxuye qinxuye changed the title BUG: To many distracted message comes from monitor_sub_pools BUG: To many distracted messages came from monitor_sub_pools Jul 10, 2023
@codingl2k1
Copy link
Contributor

Related PR: #575

@codingl2k1
Copy link
Contributor

This bug has been fixed by this PR: xorbitsai/xoscar#37. I think we should pin a higher version of xoscar. Can you try to upgrade the xoscar to 0.0.8?

@qinxuye
Copy link
Contributor Author

qinxuye commented Jul 10, 2023

Yeah, we should bump the minimal version of xoscar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants