Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix RuntimeError: cannot schedule new futures after shutdown #589

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

codingl2k1
Copy link
Contributor

@codingl2k1 codingl2k1 commented Jul 10, 2023

What do these changes do?

This error is raised because the thread pool is shutdown in incorrect order. This PR just suppresses errors.

Similar issue: dask/distributed#6087

Related issue number

Fixes #587

Fixed minimal version

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Jul 10, 2023
@XprobeBot XprobeBot added this to the v0.4.1 milestone Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #589 (cc1ed3a) into main (b8a1b4d) will increase coverage by 14.18%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #589       +/-   ##
===========================================
+ Coverage   68.49%   82.68%   +14.18%     
===========================================
  Files        1010     1010               
  Lines       78531    78531               
  Branches    16315    16315               
===========================================
+ Hits        53789    64930    +11141     
+ Misses      22572    11897    -10675     
+ Partials     2170     1704      -466     
Flag Coverage Δ
unittests 82.58% <ø> (+14.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xorbits/_mars/services/cluster/uploader.py 96.00% <ø> (-2.00%) ⬇️

... and 200 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit b02a856 into xorbitsai:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: To many distracted messages came from monitor_sub_pools
4 participants