Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Fix upload PyPI #820

Merged
merged 4 commits into from
Oct 6, 2024
Merged

BLD: Fix upload PyPI #820

merged 4 commits into from
Oct 6, 2024

Conversation

luweizheng
Copy link
Collaborator

Rollback download-artifact and upload-artifact to v3.
v4 has breaking changes, see actions/upload-artifact#478.

@XprobeBot XprobeBot added the build label Oct 6, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (662d959) to head (11603e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #820   +/-   ##
=======================================
  Coverage   82.96%   82.97%           
=======================================
  Files        1071     1071           
  Lines       80083    80083           
  Branches    16545    16545           
=======================================
+ Hits        66441    66447    +6     
+ Misses      12036    12026   -10     
- Partials     1606     1610    +4     
Flag Coverage Δ
unittests 82.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 1ec2519 into xorbitsai:main Oct 6, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants