Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to inform about deprecated modules #148

Closed
rwaffen opened this issue Sep 12, 2019 · 3 comments
Closed

add option to inform about deprecated modules #148

rwaffen opened this issue Sep 12, 2019 · 3 comments

Comments

@rwaffen
Copy link

rwaffen commented Sep 12, 2019

r10k gives you warnings like that

WARN	 -> Puppet Forge module 'arioch-redis' has been deprecated, visit https://forge.puppet.com/arioch/redis for more information.

it would be nice to have this also in g10k.

@xorpaul
Copy link
Owner

xorpaul commented Sep 13, 2019

Which g10k version are you using or are you using g10k with -quiet by any change?

g10k has this since v.0.4.8 (https://github.com/xorpaul/g10k/releases/tag/v0.4.8), but doesn't report it when using -quiet

22b628c

Resolving Git modules (1/1)    0s [====================================================================] 100%
Resolving Forge modules (1/1)    0s [====================================================================] 100%
Synced ./Puppetfile with 1 git repositories and 1 Forge modules in 0.5s with git (0.5s sync, I/O 0.0s) and Forge (0.0s query+download, I/O 0.0s) using 50 resolv and 20 extract workers

Otherwise if g10k fails to detect this please post an example Puppetfile for me to debug.

@xorpaul xorpaul closed this as completed Sep 13, 2019
@rwaffen
Copy link
Author

rwaffen commented Sep 13, 2019

Puppetfile:

mod 'arioch/redis', '3.3.0'

g10k

g10k -version
g10k version 0.7.3 Build time: 2019-09-12_16:14:21 UTC

g10k -puppetfile -verbose
2019/09/13 15:11:42 GETing https://forgeapi.puppetlabs.com/v3/files/arioch-redis-3.3.0.tar.gz took 1.03976s
2019/09/13 15:11:42 Extracting /tmp/g10k/arioch-redis-3.3.0.tar.gz took 0.94164s
Need to sync modules/redis/
2019/09/13 15:11:43 Populating modules/redis/ took 0.01984s
Synced ./Puppetfile with 0 git repositories and 1 Forge modules in 2.0s with git (0.0s sync, I/O 0.0s) and Forge (2.0s query+download, I/O 1.0s) using 50 resolv and 20 extract workers

r10k 3.3.1

    WARN	 -> Puppet Forge module 'arioch-redis' has been deprecated, visit https://forge.puppet.com/arioch/redis for more information.

xorpaul added a commit that referenced this issue Sep 13, 2019
@xorpaul
Copy link
Owner

xorpaul commented Sep 13, 2019

Ah, when you specify a version g10k would try to load this out of it's cache without contacting the Puppetlabs Forge in any way.

Seems like r10k did always query the Forge API and not use a cache like g10k did.

With v0.7.4 I've added this query to check for deprecation notices.
https://github.com/xorpaul/g10k/releases/tag/v0.7.4

If you're using many Puppetlabs Forge modules in your Puppetfile I suggest specifying a cache for that metadata/deprecation information query by adding

forge.cacheTtl 8h

or something similar to your Puppetfile(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants