Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow disabling module deprecation check or cache results #152

Closed
juliantaylor opened this issue Oct 5, 2019 · 2 comments · Fixed by #153
Closed

allow disabling module deprecation check or cache results #152

juliantaylor opened this issue Oct 5, 2019 · 2 comments · Fixed by #153

Comments

@juliantaylor
Copy link
Contributor

g10k runs significantly slower since we updated to 0.8. The reason is the forge query done also for already synced module to check for deprecation in https://github.com/xorpaul/g10k/blob/master/forge.go#L115
In our environments we more than 50 modules and the forge mirror we use is relatively slow.

Would it be possible to either disable it completely or cache the deprecation result for already synced modules so one does not have to query all modules on each update?

I could probably provide a patch.
juliantaylor added a commit to juliantaylor/g10k that referenced this issue Oct 6, 2019
@juliantaylor
Improve module deprecation check
1c1ef00 
The deprecation check queries the api each time also if the module is
already in the cache. This slows down the sync unnecessarily.

Improve this by reparsing the file when it is in the cache to continue
printing known deprecations and use the module TTL to refresh the
deprecation cache.

Closes xorpaulgh-152
@juliantaylor juliantaylor mentioned this issue Oct 6, 2019
Merged
@juliantaylor
Copy link
Contributor Author

posted #153 which prints deprecation warnings also if the module is cached and respects the module TTL to refresh the cache.

@xorpaul
Copy link
Owner

xorpaul commented Oct 7, 2019

Thanks, I really thought I already respected the Forge cache TTL setting when checking for a deprecation notice.

Looks like I only thought about it, but did not implement it.

Regarding the failing tests, I also need to fix some other things first before merging your patch.

xorpaul pushed a commit that referenced this issue Oct 8, 2019
@juliantaylor @xorpaul
Improve module deprecation check (#153)
b33fdfc 
The deprecation check queries the api each time also if the module is
already in the cache. This slows down the sync unnecessarily.

Improve this by reparsing the file when it is in the cache to continue
printing known deprecations and use the module TTL to refresh the
deprecation cache.

Closes #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve module deprecation check juliantaylor/g10k
2 participants
@juliantaylor @xorpaul