Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g10k ignores non existing git tags/branches when using -retrygitcommands #156

Closed
juliantaylor opened this issue Nov 28, 2019 · 1 comment
Assignees

Comments

@juliantaylor
Copy link
Contributor

g10k 0.8.5

when using the retrygitcommands option to g10k it ignores failures of git commands completely (at least branch/tag checks):

$ g10k   -config /tmp/config.yaml -branch somebranch  -dryrun  -retrygitcommands
Resolving Forge modules (37/37)    0s [====================================================================] 100%
Resolving Git modules (46/46)    3s [====================================================================] 100%
Synced /tmp/config.yaml with branch somebranch with 88 git repositories and 37 Forge modules in 4.7s with git (4.0s sync, I/O 0.0s) and Forge (0.0s query+download, I/O 0.0s) using 10 resolve and 5 extract workers

Same command same configuration without retry:

t$ g10k   -config /tmp/config.yaml -branch somebranch  -dryrun  
Resolving Forge modules (37/37)    0s [====================================================================] 100%
Resolving Git modules (45/46)    2s [==================================================================>-]  98%
executeCommand(): git command failed: git --git-dir /gitrepo.git rev-parse --verify 'nonexistant^{object}' exit status 128
Output: fatal: Needed a single revision

If you are using GitLab please ensure that you've added your deploy key to your repository
@xorpaul xorpaul self-assigned this Nov 28, 2019
@xorpaul
Copy link
Owner

xorpaul commented Nov 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants