Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g10k -puppetfile deletes other stuff in moduledir #75

Closed
alex-harvey-z3q opened this issue Oct 3, 2017 · 4 comments
Closed

g10k -puppetfile deletes other stuff in moduledir #75

alex-harvey-z3q opened this issue Oct 3, 2017 · 4 comments

Comments

@alex-harvey-z3q
Copy link

alex-harvey-z3q commented Oct 3, 2017

I would like to include roles and profiles in my control repo modules directory, as is common. Then I would like to use g10k to install the other modules from Puppetfile into the same directory.

It looks like r10k made this possible here. However, I see that g10k doesn't support this.

Is that something that's easy to fix?

@xorpaul
Copy link
Owner

xorpaul commented Nov 17, 2017

With v0.4.3 I added support for local modules just like r10k supports:

mod 'localstuff', :local => true
[...]

With -debug you should see something like this in your output:

DEBUG Not deleting /tmp/example/foobar_local_modules/modules/localstuff as it is declared as a local module

@baurmatt
Copy link

baurmatt commented Nov 20, 2017

The current README still mentions the local module as unsupported:

No 'local'-Modules support

Edit:
Also the :local options seems to need the value as a string rather than the (for me) preferred boolean:

Before:

Error: Can not convert local parameter value true,:install_path =>  of module external to boolean. In /etc/puppetlabs/code/environments/pp-4170/Puppetfile line: mod 'external', :local        => true,:install_path => 'modules'
 # External submodules
 mod 'external', # Ensure external folder isn't purged by g10k
-  :local        => true,
+  :local        => 'true',
   :install_path => 'modules'
 mod 'apt',
   :git          => 'https://github.com/puppetlabs/puppetlabs-apt.git', 

After:

Resolving Git modules (43/43) 1.791s [====================================================================] 100%
Synced g10k.yaml with branch pp-4170 with 49 git repositories and 0 Forge modules in 11.5s with git (4.8s sync, I/O 25.9s) and Forge (0.0s query+download, I/O 0.0s) using 50 resolv and 20 extract workers

xorpaul added a commit that referenced this issue Nov 20, 2017
@xorpaul
Copy link
Owner

xorpaul commented Nov 20, 2017

Nice catch 👍

Fixed with 5804e30

@alex-harvey-z3q
Copy link
Author

Thanks for this @xorpaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants