"Clear counts" on rfm69 does not reset node count properly.

[Trickx]

Issue: If the button "Clear counts" is pressed, the node count on the status page does not start to count anymore.

Reason: The reset code does not reset .count.

void _rfm69Clear() {
    for(unsigned int i=0; i<255; i++) {
        _rfm69_node_info[i].duplicates = 0;
        _rfm69_node_info[i].missing = 0;
    }
    _rfm69_node_count = 0;
    _rfm69_packet_count = 0;
}

Solution:

void _rfm69Clear() {
    //for(unsigned int i=0; i<255; i++) {
    for(unsigned int i=0; i<(sizeof(_rfm69_node_info)/sizeof(_node_t)); i++) {
        _rfm69_node_info[i].duplicates = 0;
        _rfm69_node_info[i].missing = 0;
        _rfm69_node_info [i].count = 0;
    }
    _rfm69_node_count = 0;
    _rfm69_packet_count = 0;
}

[lobradov]

Good catch! Care to raise a PR for a fix?

…

__ //_

On Oct 1, 2018, at 21:29, Tricx aka Trickx ***@***.***> wrote: Issue: If the button "Clear counts" is pressed, the node count on the status page does not start to count anymore. Reason: The reset code does not reset .count. void _rfm69Clear() { for(unsigned int i=0; i<255; i++) { _rfm69_node_info[i].duplicates = 0; _rfm69_node_info[i].missing = 0; } _rfm69_node_count = 0; _rfm69_packet_count = 0; } Solution: void _rfm69Clear() { //for(unsigned int i=0; i<255; i++) { for(unsigned int i=0; i<(sizeof(_rfm69_node_info)/sizeof(_node_t)); i++) { _rfm69_node_info[i].duplicates = 0; _rfm69_node_info[i].missing = 0; _rfm69_node_info [i].count = 0; } _rfm69_node_count = 0; _rfm69_packet_count = 0; } — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Trickx]

I would, but my espurna-fork is currently being used for other features - not ready for PR.
That's why I posted the fixed code here.

[lobradov]

You can always have a new branch :) Or even use online editor for small changes... __ //_

…

On Oct 1, 2018, at 21:34, Tricx aka Trickx ***@***.***> wrote: I would, but my espurna-fork is currently being used for other features - not ready for PR. That's why I posted the fixed code here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[Trickx]

-> PR #1241

[xoseperez]

Merged into dev. Thank you!