Depreciated warnings from home-assistant

[inverse]

In the last major update of home-assistant I noticed the following warnings in the logs

"platform": "mqtt" is deprecated, replace with "schema":"basic"

From researching the issue I realise It's to do with the mqtt message with auto-discovery that will need to be adjusted.

Having no expeirence with this code base would I be right in the assumption that it involves changing this line?

https://github.com/xoseperez/espurna/blob/dev/code/espurna/homeassistant.ino#L82

From:

    config.set("platform", "mqtt");

To:

    config.set("schema", "basic");

[mcspr]

Yep, it seems to be working just fine with {"schema":"basic"} addition. At first I thought this was only related to lights (searching ha github about light.mqtt_json changes), but switch component works the same. Not really sure when deprecated becomes obsolete. No mention of it here: https://github.com/home-assistant/home-assistant/blob/a9990c130dc613d83a63128375767458e52f4937/homeassistant/components/mqtt/discovery.py#L43 home-assistant/core#18227 (pr that changed this)

[inverse]

@mcspr thanks for adding more context 👍

I just reached out to the HA community and they are moving super fast and don't really time line these things out as when things will be phased out. Hopefully once they hit 1.0 they will stablise but I dont see that happening any time soon ;)

[xoseperez]

The question here is how fast people are upgrading their hass installations. Because replacing it will result in it stopping working for people with older versions. Maybe we can add both settings and remove the platform setting in a few months?

[inverse]

@xoseperez that's a very valid point. I think generally people move with the releases but supporting both would be a good solution for a while and will cover people like me who keep up and when they do finally remove the feature not be broken. What do you think?

[peterhoeg]

I have filed a feature request with HA for having it publish either its own version or an API version via MQTT. That would allow espurna to detect the format to use.

[peterhoeg]

That is assuming @xoseperez wants to go in that direction of course.

[mcspr]

@peterhoeg Have you posted the issue to the home-assistant/home-assistant about mqtt version? I would not rely on versions for this, but it might be nice to display that ESPurna device found HA presence.

"schema" / "platform" can also be avoided altogether as it falls back to the basic mqtt method (on / off / state topics) and implicitly passes "platform": "mqtt" to the configurator.
There is no json lights support -> no need to specify it right now. And no warning.
Future version must use "schema": "json" (which is from config spec, not discovery specific) to use json payloads

[peterhoeg]

@mcspr, I did on discourse as that's where they prefer feature requests: https://community.home-assistant.io/t/publish-ha-version-to-mqtt/86694

I has not received any replies though.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[stale]

This issue will be auto-closed because there hasn't been any activity for two months. Feel free to open a new one if you still experience this problem.