Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time can be offset only by full hours #265

Closed
xoseperez opened this issue Nov 1, 2017 · 3 comments
Closed

time can be offset only by full hours #265

xoseperez opened this issue Nov 1, 2017 · 3 comments
Assignees
@xoseperez
Labels
enhancement New feature or request ntp
Milestone
1.12.2

Comments

@xoseperez
Copy link
Owner

Originally reported by: Sachin Filinto (Bitbucket: sfilinto, GitHub: sfilinto)

the ntp page allows time offset in full hours only. as a result time in some cities can never be set accurately and will be 30 / 15 minutes off.
e.g. cities: adelaide, all cities in india, srilanka, and a few more.
@xoseperez
Copy link
Owner Author

Unfortunately the library I'm using at the moment only supports integer values for the offset.

@xoseperez
Copy link
Owner Author

Issue #419 was marked as a duplicate of this issue.

@xoseperez xoseperez added this to the 1.12.2 milestone Jan 24, 2018
@xoseperez xoseperez mentioned this issue Jan 24, 2018
Closed
xoseperez added a commit that referenced this issue Jan 24, 2018
@xoseperez
Updated NTPClientLib. Support for non full hour time offsets (#265)
3e4313f
@xoseperez xoseperez removed the general label Jan 25, 2018
@xoseperez xoseperez self-assigned this Jan 25, 2018
@xoseperez xoseperez added enhancement New feature or request ntp and removed minor proposal labels Jan 25, 2018
@xoseperez
Copy link
Owner Author

Will be released with 1.12.2

@xoseperez xoseperez mentioned this issue Jan 28, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xoseperez xoseperez

Labels
enhancement New feature or request ntp
Projects
None yet
Milestone
1.12.2
Development

No branches or pull requests
1 participant
@xoseperez