-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal - Serial port tight coupling #787
Comments
Setting |
Thanks please see settings.ino
(Doing some serial stuff without DEBUG_SERIAL_SUPPORT checking) also in system.ino
Serial port initializes in a way that cannot be overridden ( SERIAL_BAUDRATE initialized in general.h ), if I want to prevent any serial access or control it I need to change core code. |
I see what you mean. It shouldn't be checking SERIAL_BAUDRATE. Actually the only reason to init the Serial object when DEBUG_SERIAL_SUPPORT is 0 is because some sensor or devices uses it (rfbridge for instance), and then the init should be moved to the specific code for that sensor/device. Same thing for the default EMBEDIS_PORT value, it should be a null pointer and the StreamInjector should handle it. |
Thanks |
OK, implementation could be improved (a terminal module?) but the basics are there. No more coupling. |
@zafrirron feedback welcome |
this is handy, i was looking for a way around this. On one of my boards I'm using the Rx/Tx of UART0 to read and write values to an external serial bus (connected to my boiler) so have to rely on debug messages to telnet to see whats going on. |
For some reason there is a coupling between terminal and serial port (and in some cases debug and serial port), they should be completely separated:
It should possible not to use serial port at all (not for debug and not for terminal) and use terminal (and/or debug) thru telnet (and/or web).
The text was updated successfully, but these errors were encountered: