Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show alert on already set hostname #1035

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jul 6, 2018

Inspired by the #1030

@mcspr mcspr force-pushed the alert-haschanged branch from 7ed6110 to 6cf55da Compare July 6, 2018 10:20
@xoseperez
Copy link
Owner

Don't think this is a good idea. The previous behavior was wrong and that was the reason to force the hostname to be RFC compliant.

@mcspr
Copy link
Collaborator Author

mcspr commented Jul 10, 2018

I would argue it is the same case as device password - it does not issue an alert when already set password does not match regexp.
Maybe show a warning about possible issue but do not block configuration change? Issue mentions mqttTopic {hostname} usage which will break external topic matching. While technically correct, it breaks already working setup.

@xoseperez xoseperez merged commit 35d1d40 into xoseperez:dev Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants