Fix compiler warnings #1118

mcspr · 2018-08-08T03:47:25Z

Follow-up to the #1101 (including it here to check for warnings)

basesensor and emonsensor now force to implement methods that return some specific values. voids are optional, keeping them how they are.
fix signed/unsigned values comparison in some methods
pgm_read_dword is using reinterpret_cast<uint32_t>. conform variable type
calculateFactors last variable was not initialized. plus, initial values are all 1 anyways.
travis02/03 would show useless 'unused-variable' warnings about btnDelay. just adding button definition to use it at least once.

~~edit: 02/03 have warnings about 'decimals' being unused. this is something from 'sensors' merge.~~ Merged with 'dev'.

Add button definitions to the travis02 and travis03 IR_BUTTON should be uint32_t to properly work with new macro eepromRotate return value is not used

mcspr added 3 commits August 4, 2018 01:48

Turn off warnings only for external code

5f2a147

Force to implement BaseSensor methods that return values

fab9c0f

Fix compiler warnings

8a0b3bc

Add button definitions to the travis02 and travis03 IR_BUTTON should be uint32_t to properly work with new macro eepromRotate return value is not used

mcspr force-pushed the 1101-warnings branch from 89424b7 to 8a0b3bc Compare August 8, 2018 12:10

Merge remote-tracking branch 'origin/dev' into HEAD

17d12cd

mcspr force-pushed the 1101-warnings branch from fb8d916 to 17d12cd Compare August 8, 2018 12:22

xoseperez merged commit 4fa1c9d into xoseperez:dev Aug 8, 2018

mcspr deleted the 1101-warnings branch September 21, 2018 20:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix compiler warnings #1118

Fix compiler warnings #1118

mcspr commented Aug 8, 2018 •

edited

Loading

Fix compiler warnings #1118

Fix compiler warnings #1118

Conversation

mcspr commented Aug 8, 2018 • edited Loading

mcspr commented Aug 8, 2018 •

edited

Loading