Print each HA config entry separately #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspr
commented
Feb 8, 2019
xoseperez
reviewed
Feb 9, 2019
code/espurna/homeassistant.ino
Outdated
| @@ -317,6 +349,7 @@ void haSetup() { | |||
|
|
|||
| // Main callbacks | |||
| espurnaRegisterReload(_haConfigure); | |||
| espurnaRegisterLoop(_haLoop); | |||
There was a problem hiding this comment.
Is it really worth it to have it being checked in the main loop all the time? Wouldn't it be better t use a ticker?
There was a problem hiding this comment.
One option is to make additional API for such one-off functions to not overuse Ticker. Somehing accepting std::function with bound args.
Also see #1370
And I forgot to add check if client is actually connected...
| @@ -1366,7 +1367,9 @@ function processData(data) { | |||
| // ----------------------------------------------------------------------------- | |||
|
|
|||
| if ("haConfig" === key) { | |||
| $("#haConfig").show(); | |||
| websock.send("{}"); | |||
There was a problem hiding this comment.
Speeding up Windows <-> ESP tcp exchange. Quite noticeable.
#1387 (comment)
#1300 (comment)
There was a problem hiding this comment.
NOTE: in case DEBUG_SUPPORT is enabled, client must send something back too in response to the "weblog". Otherwise, haConfig messages are stuck behind. Gosh darnit...
mcspr
force-pushed
the
hass/stream-config
branch
from
682f08f
to
2f147ec
Compare
This comment has been minimized.
This comment has been minimized.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1233
Does involve sort-of a hack by knowing that DEBUG_MSG will not print timestamp if the last symbol is not new-line/cr-return.