Light updates #1826
Merged
Light updates #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspr
commented
Jul 15, 2019
| // Convert RGB to RGBW(W) | ||
| if (_light_has_color && _light_use_white) { | ||
| for (unsigned char i=0; i < channels; i++) { | ||
| _light_channel[i].value = _light_channel[i].inputValue * brightness; |
There was a problem hiding this comment.
Huh. I think I missed this interaction with the real values. If bound, it needs to do value = inputValue for all of the leftover channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will likely rebase & merge this as-is, so adding all 3 commits
channel <id>(i'd also move this as webui description?)@hyteoo 4702fcf restores pre-1.13.3 behaviour when
useWhiteis offif
useColoris also off, it will apply brightness to all the channels (as it does right now)