Amend #1843 #1860
Merged
Amend #1843 #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix queue include when building without Home Assistant or Alexa (#1857 (comment))
Fix gcc warning about buffer size with unsigned char (which is kind of possible with GPIO_NONE, since Shelly 1PM should probably use it instead of real pins)
Change left over from the #1843 draft where a single loop handled all the queue elements at once. Since we are handling each thing separately,
new Buffer()is called after each one finishes. That's not what we want, just create it on connection as it was before.