Update rpnlib to 0.23.x #2274
Merged
Update rpnlib to 0.23.x #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rule processing failures were not handled
std::{round,abs} should work for Core 2.3.0
Nested stacks (and nicer syntax for index...)
- fix index out of bounds - if cmp3 return value when equals For the integration: - use rpnlib helper methods, don't access internal structs - add millis, returning current unsigned timestamp - add log (accepting string) - make rpnDelay do something - try removing variables requirement, we could use 'exist' now
Merged
- fix 'swap' swapping values directly instead of swapping the stack positions - fix parser to accept empty strings as a valid token
- Revamped variable handling, use & to get ref and $ to get value
Restores old behaviour of halting execution when variable does not exist
- Fix rot, unrot, swap, over, dup and dup2 moving underlying values instead of value refs
- Fix 'empty' variable parsing ('$', '$ $', etc.) which accessed raw memory after the rule string
- Update null vs. null comparisons, `null null eq` is true
- Stringify boolean into "true" or "false"
- Add deref operator to convert &var to $var inplace
- Tweak exists operator to use reference counter instead of null value comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking rpnlib update