Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new reflection library #37

Merged
merged 4 commits into from
Jul 22, 2023
Merged

Migrate to new reflection library #37

merged 4 commits into from
Jul 22, 2023

Conversation

thekid
Copy link
Member

@thekid thekid commented Jul 18, 2023

This pull request migrates the code to use xp-framework/reflection. As this changes the API, we will releases this as a major release, 5.0.0 at the time of writing.

Performance

No measurable impact.

Before

$ xp test src/test/php
# ...
Test cases:  156 succeeded
Memory used: 3847.27 kB (3901.40 kB peak)
Time taken:  0.078 seconds (0.159 seconds overall)

After

$ xp test src/test/php
# ...
Test cases:  156 succeeded
Memory used: 3639.90 kB (3694.02 kB peak)
Time taken:  0.079 seconds (0.157 seconds overall)

See also

@thekid thekid merged commit 0988a3e into master Jul 22, 2023
18 checks passed
@thekid thekid deleted the refactor/reflection branch July 22, 2023 08:38
thekid added a commit to xp-forge/handlebars-templates that referenced this pull request Jul 22, 2023
@thekid
Copy link
Member Author

thekid commented Jul 22, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant