Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry "Exception: not primary" when writing #43

Merged
merged 12 commits into from
Sep 10, 2023
Merged

Retry "Exception: not primary" when writing #43

merged 12 commits into from
Sep 10, 2023

Commits on Sep 10, 2023

  1. Retry "Exception: not primary" when writing 

    The clientside cluster view may become outdated, causing us to erroneously write
to non-primary nodes. If we encounter an error indicating this condition, refresh
the cluster view, then retry the write once.
    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    94846f1 View commit details
    Browse the repository at this point in the history

  2. Use first server in list if "hello" does not return a primary

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    08c18a9 View commit details
    Browse the repository at this point in the history

  3. QA: Reference PR [skip ci]

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    caacdf1 View commit details
    Browse the repository at this point in the history

  4. Simplify code for handling "NotWritablePrimary" errors

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2fd5b51 View commit details
    Browse the repository at this point in the history

  5. Verify "NotWritablePrimary" errors are also handled in command sequences

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    7a73611 View commit details
    Browse the repository at this point in the history

  6. Only retry the very first command in command sequences

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    38ae8a1 View commit details
    Browse the repository at this point in the history

  7. Move NOT_PRIMARY constant to Error class

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    88d5fd1 View commit details
    Browse the repository at this point in the history

  8. Ensure only the very first command in a sequence is retried *once*

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    1b60fca View commit details
    Browse the repository at this point in the history

  9. Also execute not_writable_primary_not_retried_more_than_once w/ commands

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    f9150bb View commit details
    Browse the repository at this point in the history

  10. Fix Values annotation

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    de54dd4 View commit details
    Browse the repository at this point in the history

  11. Remove Connection::message()

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    8bcb949 View commit details
    Browse the repository at this point in the history

  12. QA: Add inline TODO comment (see xp-framework/rfc#343)

    @thekid
    thekid committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    0265d3b View commit details
    Browse the repository at this point in the history