Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated lang.Generic::getClassName() #120

Merged
merged 1 commit into from
Jan 23, 2016

Conversation

thekid
Copy link
Member

@thekid thekid commented Jan 23, 2016

  • lang.Throwable
  • lang.Object
  • Tests
  • Upgrade all libraries

See xp-framework/rfc#298

. [x] lang.Throwable
. [x] lang.Object
. [x] Tests
@thekid thekid added this to the 7.0.0 milestone Jan 23, 2016
@thekid
Copy link
Member Author

thekid commented Jan 23, 2016

Impact: Quite a bit:

Timm@slate ~/devel/xp/core [master]      
$ grep -Hirn getClassName ../*/src/|wc -l
340                                      

The fix is easy though:

  1. Replace $this->getClassName() with nameof($this)
  2. Bump dependency to minimum XP 6.3.0

thekid added a commit to xp-framework/unittest that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/sequence that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/ftp that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/geoip that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/google-authenticator that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/google-search that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/handlebars that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/http that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/imaging that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/jira-api that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/ldap that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/mail that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/markdown that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/mustache that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/nsca that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/partial that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/ratelimit that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/rdbms that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/rest that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/scriptlet that referenced this pull request Jan 23, 2016
thekid added a commit to xp-forge/stomp that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/xml that referenced this pull request Jan 23, 2016
thekid added a commit to xp-framework/zip that referenced this pull request Jan 23, 2016
@thekid thekid mentioned this pull request Jan 23, 2016
11 tasks
thekid added a commit that referenced this pull request Jan 23, 2016
Remove deprecated lang.Generic::getClassName()
@thekid thekid merged commit cc44511 into xp-framework:master Jan 23, 2016
@thekid thekid deleted the refactor/remove-getClassName branch January 23, 2016 23:32
thekid added a commit that referenced this pull request Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant