Support eval
array notation inside attributes
#324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it possible to use array notation inside attributes as follows:
Together with xp-framework/reflection#35, this is a prerequisite for extracting reflection code as proposed by xp-framework/rfc#338.
...just like PHP 8 attributes with multiple arguments do.
👉 However, this PR makes it possible to use array notation for single values or multiple named arguments without risking
ClassFormatException
s, ensuring partial compatibility.It also enables us to emit simpler code in the XP Compiler, where we current have a special-case handling for when exactly one unnamed argument exists. The simplification that can be applied there is along the lines of the following: