Skip to content
This repository has been archived by the owner on Nov 19, 2023. It is now read-only.

Use new xp-framework/reflection library #43

Closed
wants to merge 32 commits into from

Conversation

thekid
Copy link
Member

@thekid thekid commented Dec 12, 2020

See https://github.com/xp-framework/reflection. Includes support for PHP 8 idiomatic attributes as described in #40.

Comes with a slight performance hit and a memory increase in PHP 7:

Before

$ xp test src/test/php/
# ...
♥: 492/499 run (7 skipped), 492 succeeded, 0 failed
Memory used: 7290.74 kB (8016.17 kB peak)
Time taken: 0.141 seconds

Roughly the same with PHP 7.4

After

$ XP_RT=8.0 xp test src/test/php/
# ...
♥: 492/499 run (7 skipped), 492 succeeded, 0 failed
Memory used: 6925.93 kB (7723.36 kB peak)
Time taken: 0.145 seconds

$ XP_RT=7.4 xp test src/test/php/
# ...
♥: 492/499 run (7 skipped), 492 succeeded, 0 failed
Memory used: 9717.46 kB (9730.16 kB peak)
Time taken: 0.178 seconds

This is a more portable version of posix_isatty(), since it works on Windows systems too.
@thekid
Copy link
Member Author

thekid commented Dec 19, 2020

Library has reached 0.7.0 - https://github.com/xp-framework/reflection/releases/tag/v0.7.0, require at least 1.0 for merging!

@thekid
Copy link
Member Author

thekid commented Dec 20, 2020

Require at least 1.0 for merging!

Library has reached 1.0.0 - https://github.com/xp-framework/reflection/releases/tag/v1.0.0

@thekid
Copy link
Member Author

thekid commented Jan 2, 2023

Implemented as part of a completely new library without the need for all the legacy support, see https://github.com/xp-framework/test

@thekid thekid closed this Jan 2, 2023
@thekid thekid deleted the refactor/use-reflection branch January 2, 2023 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant