Use #[\SensitiveParameter] attribute for e.g. passwords

[liayn]

No description provided.

[xperseguers]

Good idea! I did it for ig_ldap_sso_auth in v4.0 :)

[liayn]

That's were I found it ;-)

[liayn]

Okay, currently we still support PHP 7.4 for v11.
I think it is okay to require PHP8.2+ now, so we can actually add this attribute.
@xperseguers What do you think?

[xperseguers]

Yes, that sounds totally legit, those still in need for PHP 7.4 or PHP 8.0 can stick on the existing version, and the new version supporting v11, v12, and possibly v13 requires PHP 8.1+, that's fair and in line with official support of PHP.

Switching to PHP 8.1+ allows to get much cleaner code, thus prone to good refactoring.

[liayn]

I'd go for PHP8.2 actually, because this attribute is supported since then only

[xperseguers]

No problem with PHP 8.1, it's just not taken into account, which doesn't hurt since it wasn't there for many versions either. And PHP 8.1 is in ELTS mode, thus I find it makes sense to keep support for it, since that extension doesn't target most up-to-date environments... https://www.php.net/supported-versions.php

[liayn]

Wasn't aware that non-supported attributes are silently ignored. Cool actually.

[xperseguers]

indeed!

[liayn]

will prepare that now then.

[xperseguers]

IIRC it would even work with PHP 7.4 but would only require to be specified on a separate line with nothing afterwards as # is considered a comment for the reste of the line until 8.0 or 8.1 where #[...] is a special comment similar to /* ... */

[liayn]

Okay, I'd still argue 8.1 is okay to raise