Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #47: static use of SaltFactory #50

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Fixes #47: static use of SaltFactory #50

merged 2 commits into from
Jan 19, 2021

Conversation

j-schumann
Copy link
Contributor

v1.0.0 of the extension uses SaltFactory::getDefaultHashInstance(TYPO3_MODE) instead of the GeneralUtility::makeInstance(SaltFactory::class)->getDefaultHashInstance(TYPO3_MODE) suggested in the developers guide.

This causes errors like this:

Core: Error handler (FE): PHP Runtime Deprecation Notice: Non-static method TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::getDefaultHashInstance() should not be called statically in [...]/typo3conf/ext/oidc/Classes/Service/AuthenticationService.php line 288

This PR fixes this error & #47.

@j-schumann j-schumann requested a review from xperseguers January 5, 2021 10:26
@xperseguers xperseguers merged commit 40c3c55 into xperseguers:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperseguers xperseguers xperseguers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-schumann @xperseguers