Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protected accolades for authenticated and active users #56

Merged
merged 11 commits into from
Sep 18, 2024

Conversation

20was
Copy link
Contributor

@20was 20was commented Aug 27, 2024

No description provided.

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xplorers-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 8:02am

src/modules/permission/NoPermissionPage.tsx Outdated Show resolved Hide resolved
src/hooks/useSlackUserStatus.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@aaasisss aaasisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change please

@20was
Copy link
Contributor Author

20was commented Sep 8, 2024

also fixes #58

@20was
Copy link
Contributor Author

20was commented Sep 10, 2024

Fixes #59 too. @boltdynamics @sonam-serchan

<ul className="flex h-screen w-full flex-col items-center justify-center gap-4 p-3">

{menus.map(({name, href, isProtected}) => (
(!isProtected || isActiveSlackUser) && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice!

Copy link
Collaborator

@sonam-serchan sonam-serchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good work!

Just formatting seems off. Would be good to keep it consistent. I need to make it run auto on commit locally. Can you please run formatting manually for now? pnpm format:fix

Copy link

Copy link
Contributor

@yashcrest yashcrest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

);

return NextResponse.json(response.data, { status: 200 });
} catch (error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need to log the errors so we know what went wrong.
maybe later

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next line is returning error but not printing in console.

Copy link
Contributor

@aaasisss aaasisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@yashcrest yashcrest merged commit fbee633 into main Sep 18, 2024
5 checks passed
@yashcrest yashcrest deleted the auth/protech-inactive branch September 18, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants