Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

모듈 분류 지정한 경우, 관리페이지에서 게시판 검색 안 되는 버그 #688

Merged
merged 3 commits into from
May 8, 2014
Merged

Conversation

lansi951
Copy link
Contributor

@lansi951 lansi951 commented May 6, 2014

@sejin7940 님 대신 풀리퀘스트 합니다.

@lansi951
Copy link
Contributor Author

lansi951 commented May 6, 2014

#687

@akasima
Copy link
Member

akasima commented May 7, 2014

@lansi951
tpl/index.html 에서 $module_category_srl 이 있을 경우 selected 될 수 있도록 되야 겠습니다.

queries/getBoardList.xml 에서 group 에 있는 module_category_srl 을 없애고 새로 작성했는데.. 혹시 이 부분을 사용하는 모듈이나 서드 파티가 있을 수 있으니 이 부분에 대한 확인이 필요하구요.
쿼리 수정으로 인한 다른 오류가 예상 된다면 condition을 추가 하고 dispBoardAdminContent 을 수정해야 하겠습니다.

@@ -89,6 +89,7 @@
<form action="" class="search x_input-append center" no-error-return-url="true">
<input loop="$param => $key, $val" cond="!in_array($key, array('mid', 'vid', 'act', 'page', 'search_target', 'search_keyword'))" type="hidden" name="{$key}" value="{$val}" />
<select cond="count($module_category)" name="module_category_srl" title="{$lang->module_category}" style="margin-right:4px">
<option value="" selected="selected"|cond="!$module_category_srl">{$lang->all}</option>
<option value="0" selected="selected"|cond="$module_category_srl==='0'">{$lang->not_exists}</option>
<option value="{$key}" loop="$module_category => $key,$val" selected="selected"|cond="$module_category==$key">{$val->title}</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selected="selected"|cond="$module_category==$key"
이 부분을 selected 될 수 있도록

selected="selected"|cond="$module_category_srl==$key"

@akasima akasima added this to the 1.7.5 milestone May 7, 2014
@akasima akasima self-assigned this May 7, 2014
@akasima
Copy link
Member

akasima commented May 8, 2014

감사합니다. :)

akasima added a commit that referenced this pull request May 8, 2014
모듈 분류 지정한 경우, 관리페이지에서 게시판 검색 안 되는 버그
@akasima akasima merged commit caf1664 into xpressengine:develop May 8, 2014
@lansi951 lansi951 deleted the board_search_fix branch May 8, 2014 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants