Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move join-json into the step library #179

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Move join-json into the step library #179

merged 1 commit into from
Jul 29, 2019

Conversation

ndw
Copy link
Collaborator

@ndw ndw commented Jul 29, 2019

Fix #110
Fix #176

@ndw ndw requested review from gimsieke, xatapult and xml-project July 29, 2019 01:11
xml-project
xml-project approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@xml-project xml-project left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Now I know, why my attempt failed.

@ndw ndw merged commit a672249 into xproc:master Jul 29, 2019
@ndw ndw deleted the move-json branch July 29, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xml-project xml-project xml-project approved these changes

@gimsieke gimsieke Awaiting requested review from gimsieke

@xatapult xatapult Awaiting requested review from xatapult

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Step document "JSON steps" could be removed. Move p:json-join to the standard step library.
2 participants
@ndw @xml-project