Fixed 1.0 left-over in p:filter #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndw
reviewed
Sep 11, 2024
steps/src/main/xml/steps/filter.xml
Outdated
| @@ -14,7 +14,7 @@ based on a (possibly dynamically constructed) XPath select expression.</para> | |||
| <p:option name="select" required="true" as="xs:string" e:type="XPathExpression"/> | |||
| </p:declare-step> | |||
|
|
|||
| <para>This step behaves just like an <tag>p:input</tag> with | |||
| <para>This step behaves just like an <tag>p:with-input</tag> with | |||
There was a problem hiding this comment.
I think you want ...just like a <tag>... here. Not "an" because "with" doesn't begin with a vowel.
|
I can merge it for you, but you should configure your git client to sign commits if you can. |
|
@ndw If you would be so kind to merge it for me. I'm wrestling with this whole "signed commits" thing, its not exactly easy... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a small 1.0 left-over in
p:filter(mentioningp:inputinstead ofp:with-input). This should fix it.