-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode coords for zarr router #178
Encode coords for zarr router #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be nice to get a test that captures the current loss of the coords. It could also help comparing if the change in extracting attrs from the un/encoded data array is going to cause issues.
The only thing missing is a test case. I will circle back to that, probably have to modify the |
for more information, see https://pre-commit.ci
…ish into miannucci-encode-coords
Added a simple test case, lemme know if we need something more comprehensive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me. Thanks Matt!
See #175
Previously, the coordinates of each DataArray were not encoded, only the dims were. So we couldnt plot this how it is shown below.
Tested with: