Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't filter or sort c14s by cal attributes #331

Open
joeroe opened this issue Feb 2, 2024 · 2 comments
Open

Can't filter or sort c14s by cal attributes #331

joeroe opened this issue Feb 2, 2024 · 2 comments

Comments

@joeroe
Copy link
Contributor

joeroe commented Feb 2, 2024

Because there's a difficult to specify many-to-many relationship based on c14_age and c14_error. Maybe the new composite primary key feature in Rails 7.1 can help? https://edgeguides.rubyonrails.org/7_1_release_notes.html#composite-primary-keys

@MartinHinz
Copy link
Collaborator

solved with 68249e4

@joeroe
Copy link
Contributor Author

joeroe commented Oct 26, 2024

@MartinHinz I think what I actually meant by this was filtering and sorting of C14s using regular Rails methods (i.e. C14.where, C14.sort) as this is what we use in the C14 index view and other places where we list dates.

I think your recent PR I only addressed filtering within the data view? Sorry for the ambiguity.

@joeroe joeroe reopened this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants