Skip to content

Conversation

@silannisik
Copy link
Contributor

🔗 #75

💡 Background and solution

Problem:
When the Cron component is used in a custom popup which is rendered from shadow root, there is a rendering issue since the popup component is calculated from the body rather then shadow root, which causing alignment issues and components like dropdown, gets rendered in the main body rather than shodow root/modal.

The Solution:
Adding getPopupContainer property from ant-design into cron which can be passed to Select component.
Now Cron components are getting rendered in the correct parent container.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Demo in storybook is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests are updated and passed without a decrease in coverage
  • Format (lint & prettier) script passed
  • Build script is working
  • README API section is updated or not needed

@xrutayisire xrutayisire merged commit 712cf4f into xrutayisire:master Apr 17, 2025
3 checks passed
@silannisik
Copy link
Contributor Author

Hi @xrutayisire thank you so much for merging these changes in a short time. Is it possible for you to release a new version with the latest changes, so we can use in our project?

@xrutayisire
Copy link
Owner

Hey, going to do that later on this afternoon 🙂

@silannisik
Copy link
Contributor Author

@xrutayisire Thank you 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add getPopupContainer from antd to Select component

2 participants