Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize: native namespace, pyproject.toml, py39+, src/, ... #14

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ThomasWaldmann
Copy link
Contributor

@ThomasWaldmann ThomasWaldmann commented Apr 10, 2024

xstatic 2.0.0

Fixes #4.
Fixes #7.
Fixes #9.
Fixes #12.

note: this is broken, because pyproject.toml does not
support pkg_resources style namespace-packages any more!
pkg_resources style was deprecated since long and pyproject.toml
has removed support for namespace-packages completely.
@ThomasWaldmann
Copy link
Contributor Author

@ReimarBauer @deshipu @jayvdb

@ThomasWaldmann
Copy link
Contributor Author

ThomasWaldmann commented Apr 10, 2024

According to the python packaging docs, I expected the pep420 change here to break all xstatic-* packages. But that does not seem to be the case (yet)!?

But maybe stuff will start breaking when some of the xstatic-* packages have adopted pep420 and some haven't yet.

@ThomasWaldmann
Copy link
Contributor Author

ThomasWaldmann commented Apr 10, 2024

Interesting: my local manual experiements with installing xstatic* packages were unproblematic (on macOS, into venv), but on github CI, there is a lot of breakage. Hah!

@ThomasWaldmann
Copy link
Contributor Author

ThomasWaldmann commented Apr 10, 2024

Note: I also added pep420 "modernize" branches in xstatic-font-awesome and xstatic-bootstrap repos here in this organisation and use them for the CI testing here.

But something is still wrong...

Is it because we have pkg.something below the xstatic package? The examples in the python packaging referenced repo had just pkg.something on top level (with pkg being the namespace package).

@ReimarBauer
Copy link

I had recently a problem with installation of something into an existing venv showing similiar problems. There it helped to force install setuptools=69.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants