-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernize: native namespace, pyproject.toml, py39+, src/, ... #14
base: master
Are you sure you want to change the base?
Conversation
note: this is broken, because pyproject.toml does not support pkg_resources style namespace-packages any more!
pkg_resources style was deprecated since long and pyproject.toml has removed support for namespace-packages completely.
According to the python packaging docs, I expected the pep420 change here to break all xstatic-* packages. But that does not seem to be the case (yet)!? But maybe stuff will start breaking when some of the xstatic-* packages have adopted pep420 and some haven't yet. |
Interesting: my local manual experiements with installing xstatic* packages were unproblematic (on macOS, into venv), but on github CI, there is a lot of breakage. Hah! |
63a41a1
to
efc819b
Compare
Note: I also added pep420 "modernize" branches in xstatic-font-awesome and xstatic-bootstrap repos here in this organisation and use them for the CI testing here. But something is still wrong... Is it because we have |
I had recently a problem with installation of something into an existing venv showing similiar problems. There it helped to force install setuptools=69.5.1 |
xstatic 2.0.0
Fixes #4.
Fixes #7.
Fixes #9.
Fixes #12.