Switch to libsodium #77
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xt0rted
force-pushed
the
libsodium-migration
branch
from
c8442b9 to
c9dd926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us over to
libsodiumnow thattweetsodiumis unmaintained and deprecated in favor of this library.Due to an issue with webpack/ncc bundling a cjs library to esm doesn't work. Running the bundled output results in the following error:
Replacing
__dirnamein the bundled output withprocess.cwd()gets things working. Ideally this would be fixed in webpack/ncc, but libsodium packaging an esm build would also work. So until one of those things happens this can't be merged.ref: jedisct1/libsodium.js#263
ref: vercel/ncc#749