Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change uses of whitelist to allowlist in translate_readme.py. #1634

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

xwxtwd
Copy link
Contributor

@xwxtwd xwxtwd commented Feb 26, 2024

1.Change uses of whitelist to allowlist in translate_readme.py.
2.Change uses of blacklist to blocklist in translate_readme.py.
3.Change uses of blacklisted to blocklisted in translate_readme.py.

Change uses of blacklist to blocklist in translate_readme.py.
Change uses of blacklisted to blocklisted in translate_readme.py.
Copy link

@J.Son, thank you for contributing to the project by initiating the pull request titled "Change uses of whitelist to allowlist in translate_readme.py." Your effort to modernize the language in our codebase is greatly appreciated.

Review Summary:

  • Overall Impression: Positive. The changes proposed align well with contemporary standards for inclusive language in software development.
  • Compatibility: No compatibility issues identified. The changes are limited to variable naming and should not affect the functionality of translate_readme.py.
  • Code Quality: Good. The updated variable names (allowlist and blocklist) are clear and self-explanatory.

Detailed Comments:

  1. Clarity and Maintainability: The PR enhances code clarity by adopting more descriptive and inclusive terminology. This not only aligns with modern best practices but also makes the codebase more welcoming and easier to understand for new contributors.
  2. Consistency: The changes maintain consistency throughout the file. By updating all occurrences of the outdated terms to their newer counterparts, you've ensured that the code is uniformly updated.
  3. Potential Improvements: While not strictly necessary, consider reviewing other files in the codebase for similar language updates. Consistency across the entire project would further reinforce the shift towards more inclusive terminology.
  4. Documentation: It might be beneficial to update any relevant documentation or readme files that reference these terms, ensuring that the terminology is consistent across both the code and its accompanying documents.

Action Items:

  • For Maintainers: No additional changes are requested at this time. This PR is ready for merge pending any final checks.
  • For @J.Son: Great job on this PR! If there are any other files where you think similar changes could be applied, feel free to initiate additional pull requests.

Again, thank you, @J.Son, for your valuable contribution. Your efforts to make our project's language more inclusive are immensely appreciated. Looking forward to your continued involvement!

@hlohaus hlohaus merged commit c2f2927 into xtekky:main Feb 26, 2024
1 check passed
@hlohaus
Copy link
Collaborator

hlohaus commented Feb 26, 2024

Thank you
Are you using translate_readme.py for your project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants