Fix issue reading provider model list

[hlohaus]

No description provided.

[github-actions]

Pull Request Review

Title: Fix issue reading provider model list

Thank you, @hlohaus, for contributing to the project! I’ve reviewed the changes in your pull request and have the following feedback:

---

Feedback

Change Summary:

• The PR modifies how the URL for the provider model list is constructed in the api() function inside the chat.v1.js file.
• Previously, a URL object was being created unnecessarily, and the new change simplifies this by using a string concatenation approach for the url variable.

Improvements and Impact:

1. Redundant Code Removal:

   • The unnecessary use of the URL constructor is removed, making the function cleaner and easier to understand.

2. Correct URL Handling for models Resource:

   • For the case when ressource == 'models', the new logic directly updates the URL variable with the expected path and query arguments, fixing the issue in reading the provider model list.

Suggestions:

• Consistency in Base URL Management: While the change fixes the immediate issue, consider making the base API URL configurable in a single place (e.g., a global variable) to increase maintainability and reduce potential hardcoding errors.
• Unit Tests: If the project has a test suite, it would be beneficial to add (or update) tests to ensure the new URL handling logic works as expected for this and related resources.

---

Approval

This change looks good overall, and the issue seems to be resolved with the adjustments you made. Please let me know if you want me to review any additional changes.

---

Thank you again, @hlohaus, for improving the project and ensuring its functionality is robust.

Best regards,
g4f Copilot