Fix various compiler warnings #2801
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I note this overlaps to some part with #2781; is there a reason that PR has not been merged? |
These solve warnings when compiled with gcc 14 using a set of warnings enabled that we use in one of our projects: -Wall -Wnon-virtual-dtor -Wzero-as-null-pointer-constant -Wduplicated-branches -Wundef -Wvla -Wpointer-arith -Wextra -Wno-unused-parameter
aroffringa
force-pushed
the
fix-warnings
branch
from
329d5ee
to
9c68fbd
Compare
JohanMabille
requested changes
Nov 20, 2024
include/xtensor/xassign.hpp
Outdated
| // in compilation error for expressions that do not provide a SIMD interface. | ||
| // simd_assign is true if simd_linear_assign() or simd_linear_assign(de1, de2) | ||
| // is true. | ||
| if constexpr(simd_assign) { |
There was a problem hiding this comment.
This is C++17 while we advertise that xtensor is compatible with C++14.
There was a problem hiding this comment.
Thanks, that's good to know. I've changed the fix by using #pragma GCC statements to not get the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These solve warnings when compiled with gcc 14 using a set of warnings enabled that we use in one of our projects:
-Wall
-Wnon-virtual-dtor
-Wzero-as-null-pointer-constant
-Wduplicated-branches
-Wundef
-Wvla
-Wpointer-arith
-Wextra
-Wno-unused-parameter
Checklist
Description