Add JSON serialization and deserialization of xtensor containers #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
reviewed
May 1, 2018
| detail::json_shape(j, s); | ||
|
|
||
| // In the case of a view, we check the size of the container. | ||
| if (!std::equal(s.cbegin(), s.cend(), e.shape().cbegin())) |
There was a problem hiding this comment.
maybe we should factor this out, like in xt::resize_container and make a xt::resize_expression free function, that resizes in the case of a container_semantic and throws if shape is wrong in case of view_semantic?
Could be useful for other cases in the future.
SylvainCorlay
force-pushed
the
xjson
branch
4 times, most recently
from
d04365a to
ac8bded
Compare
SylvainCorlay
commented
May 2, 2018
include/xtensor/xjson.hpp
Outdated
| enable_xcontainer<E> from_json(const nlohmann::json&, E&); | ||
|
|
||
| template <class E> | ||
| enable_xview<E> from_json(const nlohmann::json&, E&); |
There was a problem hiding this comment.
Should we call this enable_xview_semantics instead? (idem for containers)
|
Added some documentation. Despite |
|
Hum, I am getting this sort of error in the documentation because of the multiple matches despite of the
|
|
OK, the documentation issue is fixed. This is ready to go IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.