Merge pull request #2435 from Tyriar/r4_0_2433

Fix NPE when open called twice (release/4.0)
xtermjs · Sep 23, 2019 · ac69ef5 · ac69ef5
2 parents 217ed05 + b28be87
commit ac69ef5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Terminal.ts b/src/Terminal.ts
@@ -604,8 +604,8 @@ export class Terminal extends Disposable implements ITerminal, IDisposable, IInp
  // Performance: Add viewport and helper elements from the fragment
  this.element.appendChild(fragment);
 
- this._theme = this.options.theme;
- this.options.theme = null;
+ this._theme = this.options.theme || this._theme;
+ this.options.theme = undefined;
  this._colorManager = new ColorManager(document, this.options.allowTransparency);
  this._colorManager.setTheme(this._theme);