Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out addon builds from lib build #1674

Closed
Tyriar opened this issue Sep 9, 2018 · 0 comments
Closed

Split out addon builds from lib build #1674

Tyriar opened this issue Sep 9, 2018 · 0 comments
Assignees
@Tyriar
Labels
area/build Regarding the build process type/debt Technical debt that could slow us down in the long run
Milestone
3.8.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 9, 2018

After sitting on the current build for a while I've found it hard to parse the current watch task:

screen shot 2018-09-09 at 7 24 36 am

I think we should split out all the addons into a watch-addons task as they're much more rarely worked on, we should still make sure addons are still built on yarn.
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Sep 9, 2018
@Tyriar Tyriar self-assigned this Sep 9, 2018
@Tyriar Tyriar added the area/build Regarding the build process label Sep 9, 2018
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 9, 2018
@Tyriar
Split addon watch into watch-addons
e59fef8 
Fixes xtermjs#1674
@Tyriar Tyriar mentioned this issue Sep 9, 2018
Merged
@Tyriar Tyriar added this to the 3.8.0 milestone Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/build Regarding the build process type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
3.8.0
Development

No branches or pull requests
1 participant
@Tyriar