Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CJK characters are being rendered with incorrect glyph with the canvas/dynamic renderer #1757

Closed
Tyriar opened this issue Oct 15, 2018 · 1 comment
Closed

CJK characters are being rendered with incorrect glyph with the canvas/dynamic renderer #1757

Tyriar opened this issue Oct 15, 2018 · 1 comment
Assignees
@Tyriar
Labels
type/bug Something is misbehaving
Milestone
3.9.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 15, 2018

image

microsoft/vscode#60865
@Tyriar Tyriar added type/bug Something is misbehaving area/renderer labels Oct 15, 2018
@Tyriar Tyriar added this to the 3.9.0 milestone Oct 15, 2018
@Tyriar Tyriar self-assigned this Oct 15, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Oct 15, 2018

Cause:

screen shot 2018-10-15 at 11 29 05 am

We don't validate that a character is cacheable.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 15, 2018
@Tyriar
Move dynamic atlas canCache check higher
a53aaa5 
Fixes xtermjs#1757
@Tyriar Tyriar mentioned this issue Oct 15, 2018
Merged
Tyriar added a commit to microsoft/xterm.js that referenced this issue Oct 15, 2018
@Tyriar
Move dynamic atlas canCache check higher
86f9b66 
Fixes xtermjs#1757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
3.9.0
Development

No branches or pull requests
1 participant
@Tyriar