Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for CSI handlers #2117

Open
16 of 36 tasks
Tyriar opened this issue May 22, 2019 · 2 comments
Open
16 of 36 tasks

Add tests for CSI handlers #2117

Tyriar opened this issue May 22, 2019 · 2 comments
Labels
help wanted type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented May 22, 2019

  • @
  • A
  • B
  • C
  • D
  • E
  • F
  • G
  • H
  • I
  • J
  • K
  • L
  • M
  • P
  • S
  • T
  • X
  • Z
  • `
  • a
  • b
  • c
  • d
  • e
  • f
  • g
  • h (some but incomplete)
  • l
  • m
  • n
  • p
  • q
  • r
  • s
  • u
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label May 22, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 22, 2019
@jerch
Copy link
Member

jerch commented May 24, 2019

@Tyriar Really nice to get those rolling now we have puppeteer. Once they reach a critical coverage, we can even get rid of the terminal tests with those ugly escape sequence test files.

Furthermore we still have many blind spots regarding correct sequence handling (xterm.js still fails badly in vttest for many tests) which can be fixed gradually with a strong test base.

@Tyriar
Copy link
Member Author

Tyriar commented May 24, 2019

Yeah it feels good knowing that we won't break DSR again, that caused a bunch of random issues sitting in VS Code for a few days.

I like the escape sequence tests, just the way they're implemented feels a bit messy. Pretty sure many of the failures they exhibit are bugs/missing functionality from xterm.

Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 26, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jun 1, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 14, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 14, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 14, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

No branches or pull requests

2 participants