-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for CSI handlers #2117
Comments
Part of xtermjs#2117
@Tyriar Really nice to get those rolling now we have puppeteer. Once they reach a critical coverage, we can even get rid of the terminal tests with those ugly escape sequence test files. Furthermore we still have many blind spots regarding correct sequence handling (xterm.js still fails badly in |
Yeah it feels good knowing that we won't break DSR again, that caused a bunch of random issues sitting in VS Code for a few days. I like the escape sequence tests, just the way they're implemented feels a bit messy. Pretty sure many of the failures they exhibit are bugs/missing functionality from xterm. |
Part of xtermjs#2170 Part of xtermjs#2117
The text was updated successfully, but these errors were encountered: