Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft reset (DECSTR) breaks the default attribute #2196

Closed
Tyriar opened this issue Jun 6, 2019 · 3 comments · Fixed by #2197
Closed

Soft reset (DECSTR) breaks the default attribute #2196

Tyriar opened this issue Jun 6, 2019 · 3 comments · Fixed by #2197
Assignees
@Tyriar
Labels
type/bug Something is misbehaving
Milestone
3.14.4

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 6, 2019

Causing input text to become bold:

microsoft/vscode#75021

I was seeing strange things as well where it would become bold, colored and dimmed.

These changes seem to carry over to new terminal as well which indicates to me the char atlas gets corrupted after a reset.

Screen Shot 2019-06-06 at 2 12 58 PM
@Tyriar Tyriar added the type/bug Something is misbehaving label Jun 6, 2019
@Tyriar Tyriar added this to the 4.0.0 milestone Jun 6, 2019
@Tyriar Tyriar mentioned this issue Jun 6, 2019
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jun 6, 2019

See microsoft/vscode#74940 as well

@Tyriar
Copy link
Member Author

Tyriar commented Jun 6, 2019

FYI @jerch

@Tyriar Tyriar self-assigned this Jun 6, 2019
Tyriar added a commit that referenced this issue Jun 6, 2019
@Tyriar
Properly clone default attr data on DECSTR
61f5726 
Fixes #2196
@Tyriar Tyriar mentioned this issue Jun 6, 2019
Merged
Tyriar added a commit that referenced this issue Jun 6, 2019
@Tyriar
Properly clone default attr data on DECSTR
767eec3 
Fixes #2196
@Tyriar Tyriar changed the title Weird things happen after running reset Soft reset (DECSTR) breaks the default attribute Jun 6, 2019
Tyriar added a commit to microsoft/xterm.js that referenced this issue Jun 11, 2019
@Tyriar
Properly clone default attr data on DECSTR
01de575 
Fixes xtermjs#2196
@Tyriar Tyriar mentioned this issue Jun 12, 2019
Merged
This was referenced Jun 25, 2019
Closed
Closed
@Tyriar Tyriar modified the milestones: 4.0.0, 3.14.3 Jun 26, 2019
@Tyriar Tyriar reopened this Jun 26, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jun 26, 2019

Also affects 3.14, should do a patch release

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jun 26, 2019
@Tyriar
Properly clone default attr data on DECSTR
77b7969 
Fixes xtermjs#2196
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jun 26, 2019
@Tyriar
Fix soft reset breaking default attribute
63b2581 
Fixes xtermjs#2196
@Tyriar Tyriar mentioned this issue Jun 26, 2019
Merged
@Tyriar Tyriar closed this as completed Jun 26, 2019
@snyk-bot snyk-bot mentioned this issue Apr 7, 2020
Open
@snyk-bot snyk-bot mentioned this issue Apr 22, 2020
Open
@renovate renovate bot mentioned this issue Jun 6, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
3.14.4
Development

Successfully merging a pull request may close this issue.

Properly clone default attr data on DECSTR xtermjs/xterm.js
1 participant
@Tyriar