Cannot read property 'setTheme' of undefined

[kind-serge]

Hi, we've had such code:

this.terminal.setOption('theme', ....);
this.terminal.open(....);

However, with the latest changes, the internal _colorManager gets initialized on .open(), thus the first line fails with:

TypeError: Cannot read property 'setTheme' of undefined
    at e._setTheme (Terminal.js.pre-build-optimizer.js:587)
    at e.setOption (Terminal.js.pre-build-optimizer.js:307)
    at t.setOption (Terminal.js.pre-build-optimizer.js:193)

It's an easy fix on our side (just swap two lines), however, it makes sense to decouple visual customization from connectivity responsibilities. Was it an unintentional change?

[Tyriar]

I think this is already fixed in the latest release https://github.com/xtermjs/xterm.js/releases/tag/3.14.2, #2179

[kind-serge]

@Tyriar, it's a new unresolved issue.
If you look at line 622 in Terminal.ts in master - that's the only place where _colorManager is initialized - the open function.

[Tyriar]

Thanks for the follow up, fixing now 😃

[kind-serge]

Thank you for making it real :)

[Tyriar]

We should be able to entirely avoid these issues when this part is moved to TS strict mode, can't wait but it's a bit of a beast of a project #1507