-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bell handling #3316
Comments
It might not even be worth having a bell addon but just giving an example sound in the docs? The sound addon one is a different thing imo |
Yes a bell-addon on its own is not very useful imho. My thoughts are - remove the sound service in v5 from core repo and just go with the For the sound-addon I need a |
Pushed to v5 branch |
(Coming from #3314.)
Consolidate bell handling as follows:
onBell
as interface to hook into the bell (make sound output an outer env problem). Here integrators can do whatever they want or suits their purpose.onBell
. If demanded, we can later extend the addon by other bell metaphors, like a visual bell and such.This cannot be done until next major release version (v5), as it involves changes to the terminal options.
The text was updated successfully, but these errors were encountered: