Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression - Emoji Panel not working #3629

Closed
LabhanshAgrawal opened this issue Feb 7, 2022 · 4 comments
Closed

Regression - Emoji Panel not working #3629

LabhanshAgrawal opened this issue Feb 7, 2022 · 4 comments

Comments

@LabhanshAgrawal
Copy link
Contributor

Details

  • Browser and browser version: Chrome 97
  • OS version: macOS 11.6.2
  • xterm.js version: 4.17

Steps to reproduce

  1. Run the demo
  2. Input anything using the Emoji panel

This broke in #3535 and works on reverting that (can't just do that and merge, as it's needed to prevent duplicate input)

xterm_emoji.mp4
@lgarron
Copy link

lgarron commented Feb 7, 2022

Can confirm that this is also broken for me in VSCode on macOS — I thought something was wrong with the computer!

@hello-smile6
Copy link
Contributor

Can reproduce on Chromium OS, build by @google with API keys.

@Tyriar
Copy link
Member

Tyriar commented Dec 12, 2024

This is too stale and AFAICT it works fine with xterm.js in VS Code

@Tyriar Tyriar closed this as completed Dec 12, 2024
@lgarron
Copy link

lgarron commented Dec 15, 2024

This is too stale and AFAICT it works fine with xterm.js in VS Code

Can confirm as well!

Sometimes the emoji palette appears in the upper left of the screen because it doesn't know where the cursor is, but this usually still allows emoji input and corrects itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants