Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input: prevent duplicate IME input on Linux - fixes #3533 #3535

Merged
merged 3 commits into from
Dec 17, 2021
Merged

input: prevent duplicate IME input on Linux - fixes #3533 #3535

merged 3 commits into from
Dec 17, 2021

Conversation

Eugeny
Copy link
Member

@Eugeny Eugeny commented Oct 31, 2021

This prevents both input and keyup triggering the same data event with Sogou IME on Linux.

The PR should be pretty safe as it only further filters the recently added input event handler.

@Eugeny Eugeny requested a review from Tyriar November 8, 2021 16:35
@ccat3z ccat3z mentioned this pull request Dec 17, 2021
Closed
@Tyriar Tyriar added this to the 4.16.0 milestone Dec 17, 2021
Tyriar
Tyriar approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay 👍

@Tyriar Tyriar merged commit 5facfe5 into xtermjs:master Dec 17, 2021
This was referenced Feb 6, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Eugeny @Tyriar