Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find result decorations misaligned in dom renderer #3705

Closed
meganrogge opened this issue Mar 23, 2022 · 0 comments · Fixed by #3710 or #3711
Closed

Find result decorations misaligned in dom renderer #3705

meganrogge opened this issue Mar 23, 2022 · 0 comments · Fixed by #3710 or #3711
Labels
area/decorations area/renderer-dom
Milestone
4.19.0

Comments

@meganrogge
Copy link
Member

Discovered here microsoft/vscode#145808
@Tyriar Tyriar added this to the 4.19.0 milestone Mar 23, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 24, 2022
@Tyriar
Don't override decoration positions
24fb498 
This also fixes an exception that was throwing where we only allowed links
within the terminal's 'rows', which should have been buffer length

Fixes xtermjs#3705
Part of microsoft/vscode#145808
@Tyriar Tyriar mentioned this issue Mar 24, 2022
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 24, 2022
@Tyriar
Don't change overview ruler position based on decorations
02795f8 
The original fix for xtermjs#3705 ended up revealing this other bug; the canvas
shouldn't be set based on the anchor of its decorations.

Fixes xtermjs#3705
@Tyriar Tyriar mentioned this issue Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/decorations area/renderer-dom
Projects
None yet
Milestone
4.19.0
2 participants
@Tyriar @meganrogge