Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow minimum contrast ratio to go in both directions if needed #3720

Closed
Tyriar opened this issue Mar 30, 2022 · 1 comment · Fixed by #3806
Closed

Allow minimum contrast ratio to go in both directions if needed #3720

Tyriar opened this issue Mar 30, 2022 · 1 comment · Fixed by #3806
Assignees
@Tyriar
Labels
area/accessibility type/enhancement Features or improvements to existing features
Milestone
4.19.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 30, 2022

Context: microsoft/vscode#145973 (comment)

The minimum contrast ratio should make this black text white/light gray:

image

It does not currently because we only move the fg color away from the bg color, we should instead invert the foreground and go in the other direction if necessary.
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/accessibility labels Mar 30, 2022
@Tyriar Tyriar mentioned this issue Mar 30, 2022
Closed
@Tyriar
Copy link
Member Author

Tyriar commented May 13, 2022

An even worse problem is white on white where the text becomes invisible.

@Tyriar Tyriar added this to the 4.19.0 milestone May 13, 2022
@Tyriar Tyriar self-assigned this May 13, 2022
This was referenced May 13, 2022
Closed
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 13, 2022
@Tyriar
Allow ensureContrastRatio to change luminance the other way
de03391 
The higher ratio of the two results will be picked.

Fixes xtermjs#3720
@Tyriar Tyriar mentioned this issue May 13, 2022
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 13, 2022
@Tyriar
Whitespace change to trigger build
d7fb014 
The fix for xtermjs#3720 didn't touch any file in the webgl addon so it didn't end
up releasing.
This was referenced May 13, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/accessibility type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
4.19.0
Development

Successfully merging a pull request may close this issue.

Allow ensureContrastRatio to change luminance the other way Tyriar/xterm.js
1 participant
@Tyriar