Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn test-api is running unit tests as well #3777

Closed
Tyriar opened this issue May 11, 2022 · 0 comments · Fixed by #3934
Closed

yarn test-api is running unit tests as well #3777

Tyriar opened this issue May 11, 2022 · 0 comments · Fixed by #3934
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 11, 2022

This is meant to only run the api/playwright tests but seems to be including unit tests

https://dev.azure.com/xtermjs/xterm.js/_build/results?buildId=5256&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=5852bf5a-5a02-52f3-bee8-4fdc90cda9d0
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label May 11, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 25, 2022
@Tyriar
Fix test-api running unit tests as well
8c55c83 
This file was added to support the mocha test explorer in vscode
but it turns out it causes all calls to mocha to run the unit
tests. I couldn't figure out how to ignore through args.

Fixes xtermjs#3777
@Tyriar Tyriar mentioned this issue Jul 25, 2022
Merged
@Tyriar Tyriar added this to the 4.20.0 milestone Jul 25, 2022
@Tyriar Tyriar self-assigned this Jul 25, 2022
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix test-api running unit tests as well Tyriar/xterm.js
1 participant
@Tyriar