Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoration top layer backgroundColor is drawn underneath selection on DOM renderer #3799

Closed
Tyriar opened this issue May 13, 2022 · 0 comments · Fixed by #3800
Closed

Decoration top layer backgroundColor is drawn underneath selection on DOM renderer #3799

Tyriar opened this issue May 13, 2022 · 0 comments · Fixed by #3800
Assignees
@Tyriar
Labels
area/renderer-dom type/bug Something is misbehaving
Milestone
4.19.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 13, 2022

Oversight, should be easy to support in DOM renderer.
@Tyriar Tyriar added type/bug Something is misbehaving area/renderer-dom labels May 13, 2022
@Tyriar Tyriar added this to the 4.19.0 milestone May 13, 2022
@Tyriar Tyriar self-assigned this May 13, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 13, 2022
@Tyriar
Dom renderer: top decorations above selection
1a50cfa 
Fixes xtermjs#3799
@Tyriar Tyriar mentioned this issue May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/renderer-dom type/bug Something is misbehaving
Projects
None yet
Milestone
4.19.0
Development

Successfully merging a pull request may close this issue.

Dom renderer: top decorations above selection Tyriar/xterm.js
1 participant
@Tyriar